Fix ConstNode#absolute? raising NoMethodError when the constant is not namespaced
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
force-pushed
the
fix-const-node-ancestor
branch
from
0621fd4
to
d0383b2
Compare
…s not namespaced.
dvandersluis
force-pushed
the
fix-const-node-ancestor
branch
from
d0383b2
to
ce7d43d
Compare
dvandersluis
changed the title
ConstNode#ancestor? raising NoMethodError when the constant is not namespacedConstNode#absolute? raising NoMethodError when the constant is not namespaced
|
Oops, good catch, thanks! |
|
Released in v0.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up in rubocop/rubocop#8738.
When there is no namespace,
each_path.firstis nil, which caused