Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type lists should be sets #22

Closed
marcandre opened this issue Jun 4, 2020 · 1 comment
Closed

Type lists should be sets #22

marcandre opened this issue Jun 4, 2020 · 1 comment
Milestone
1.0.0

Comments

@marcandre
Copy link
Contributor

E.g. TRUTHY_LITERALS

Although there's not much valid reason to use them directly, this could break some code relying on them, e.g. [...] - Set[...] TypeError (no implicit conversion of Set into Array), so v1 might be a good time...
@marcandre marcandre added this to the 1.0.0 milestone Jun 4, 2020
This was referenced Jun 6, 2020
Closed
Closed
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 7, 2020
@marcandre
Use Sets instead of Arrays [rubocop#22]
8574f32
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 7, 2020
@marcandre
[fixes rubocop#22] Use Sets instead of Arrays
4fd84e5
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 9, 2020
@marcandre
[fixes rubocop#22] Use Sets instead of Arrays
11340d9
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce List, a frozen Array/Set
c41dfe8
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array/Set
9ed51b1
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array/Set
c0099ed
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array/Set
231b4d6
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array/Set
b6fc172
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 10, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array/Set
a1af995
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 11, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array with fast include?
e5117a8
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 11, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array with fast include?
9fbfca5
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 24, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array with fast include?
53dcf85
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 24, 2020
@marcandre
[fixes rubocop#22] Introduce Tuple, a frozen Array with fast include?
b03f186
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 25, 2020
@marcandre
[fixes rubocop#22] Introduce FastArray, a frozen Array with fast `inc…
6b2ee9f 
…lude?`
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jun 25, 2020
@marcandre
[fixes rubocop#22] Introduce FastArray, a frozen Array with fast `inc…
0ed0c17 
…lude?`
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jul 7, 2020
@marcandre
[Fixes rubocop#22] AutoConstToSet builds Set variants of constants au…
ba52244 
…tomatically
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jul 7, 2020
@marcandre
[Fixes rubocop#22] AutoConstToSet builds Set variants of constants au…
3ac79b9 
…tomatically
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jul 7, 2020
@marcandre
[Fixes rubocop#22] AutoConstToSet builds Set variants of constants au…
4ee442b 
…tomatically
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Jul 7, 2020
@marcandre
[Fixes rubocop#22] AutoConstToSet builds Set variants of constants au…
cd39721 
…tomatically
@marcandre
Copy link
Contributor Author

This has been resolved for rubocop-ast, with most constants now private and the rest converted to Sets.

Closing this and related PRs.

ashkulz added a commit to prontolabs/pronto-rubocop that referenced this issue Feb 13, 2021
@ashkulz
block support for RuboCop 0.84.0
d79bff6 
This was the first version to use rubocop-ast, and unfortunately
the dependency is loose enough that rubocop-ast versions >= 0.7.0
are allowed, which cause require 'rubocop' to fail with

  NoMethodError:
    undefined method `join' for #<Set: {:==, :===, :!=, :<=, :>=, :>, :<}>
  # rubocop-0.84.0/lib/rubocop/cop/style/redundant_conditional.rb:57:in `<class:RedundantConditional>'

This is due to rubocop/rubocop-ast#22
and it's too much effort to pin that dependency and hence easier
to just block the version instead.
ashkulz added a commit to prontolabs/pronto-rubocop that referenced this issue Feb 13, 2021
@ashkulz
fix support for RuboCop 0.84.0 and 0.85.x
18baa3c 
These were the first versions to use rubocop-ast, and unfortunately
the dependency is loose enough that rubocop-ast versions >= 0.7.0
are allowed, which cause require 'rubocop' to fail with

  NoMethodError:
    undefined method `join' for #<Set: {:==, :===, :!=, :<=, :>=, :>, :<}>
  in rubocop-0.84.0/lib/rubocop/cop/style/redundant_conditional.rb:57:in `<class:RedundantConditional>'

This is due to rubocop/rubocop-ast#22
so just block those versions directly. This has the unfortunate
side effect of requiring rubocop-ast for older versions which
don't require it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@marcandre