Improve parent_module_name
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR, when Rubocop::AST::Node#parent_module_name_part is executed, it will no longer do non-local exits when a block is evaluated, and evaluating singleton_class or block in Rubocop::AST::Node#parent_module_name will behave as expected. With this change, this PR aims to resolve the following issue. rubocop/rubocop#5022
|
I'm fine with both proposals, although I'm leaning slightly towards the second option. |
|
Merging as is, further improvements welcome |
marcandre
added a commit
that referenced
this pull request
May 26, 2021
This reverts commit e303401.
|
I'm not sure how come the test suite was green. This deteriorates even some simple cases. Reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #176
@sanfrecce-osaka:
This still isn't quite right as the result with
duplicate_methodcop isn't quite right, and it gets confused betweenFoo.methodandFoo::#<Class:Foo>#method(correct but not as nice).I'm not sure if it's best to change the cop, or add an
Nodemethod forqualified_nameor something.