configure.rb: Add alternate gettid() header (unistd.h)
#3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux systems providing gettid(), the header is `unistd.h`, which is currently not evaluated. The conseguence of this omission is that Rubinius' gettid() definition conflicts with Glibc's one - the former doesn't have the noexcept specifier, while the latter does (__THROW).
64kramsystem
added a commit
to 64kramsystem/rvm-dev
that referenced
this pull request
Mar 31, 2022
On Linux systems providing gettid() (Glibc 2.30+), the header is `unistd.h`, so the function must be tested also using such header. Upstream PR: rubinius/rubinius#3848. I've included it only from v4.7, because I can't produce a working Rubinius interpreter with the previous versions.
|
Closing for inactivity. |
64kramsystem
added a commit
to 64kramsystem/rvm-dev
that referenced
this pull request
May 2, 2022
On Linux systems providing gettid() (Glibc 2.30+), the header is `unistd.h`, so the function must be tested also using such header. Upstream PR: rubinius/rubinius#3848. I've included it only from v4.7, because I can't produce a working Rubinius interpreter with the previous versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux systems providing gettid(), the header is
unistd.h, which is currently not evaluated. The consequence of this omission is that Rubinius' gettid() definition conflicts with Glibc's one - the former doesn't have the noexcept specifier, while the latter does (__THROW).Closes #3847.
Extra context: this was not detected before because gettid() has been introduced on Glibc 2.30, which is not very old.