Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build 0.4 docs from the v0.4.x branch #266

Merged
merged 1 commit into from Nov 6, 2019
Merged

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Oct 25, 2019

instead of using a specific tag; this way documentation changes done to the
v0.4.x branch will show up on the site as soon as they land -- right now they
require publishing a new v0.4.x release on crates.io

instead of using a specific tag; this way documentation changes done to the
v0.4.x branch will show up on the site as soon as they land -- right now they
require publishing a new v0.4.x release on crates.io and manually updating the
`after-success.sh` build script on master
Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 26, 2019
266: CI: build 0.4 docs from the v0.4.x branch r=korken89 a=japaric

instead of using a specific tag; this way documentation changes done to the
v0.4.x branch will show up on the site as soon as they land -- right now they
require publishing a new v0.4.x release on crates.io

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Build failed

@korken89
Copy link
Collaborator

korken89 commented Nov 6, 2019

bors retry

bors bot added a commit that referenced this pull request Nov 6, 2019
266: CI: build 0.4 docs from the v0.4.x branch r=korken89 a=japaric

instead of using a specific tag; this way documentation changes done to the
v0.4.x branch will show up on the site as soon as they land -- right now they
require publishing a new v0.4.x release on crates.io

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Nov 6, 2019

Build failed

@korken89
Copy link
Collaborator

korken89 commented Nov 6, 2019

bors retry

bors bot added a commit that referenced this pull request Nov 6, 2019
266: CI: build 0.4 docs from the v0.4.x branch r=korken89 a=japaric

instead of using a specific tag; this way documentation changes done to the
v0.4.x branch will show up on the site as soon as they land -- right now they
require publishing a new v0.4.x release on crates.io

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Nov 6, 2019

Build succeeded

@bors bors bot merged commit 3dd6df0 into master Nov 6, 2019
@bors bors bot deleted the ci-latest-v4-docs branch November 6, 2019 21:09
andrewgazelka pushed a commit to andrewgazelka/cortex-m-rtic that referenced this pull request Nov 3, 2021
287: Fix common uses of INSERT AFTER with .bss and .text r=adamgreig a=mattico

Fixes rtic-rs#267 
Fixes rtic-rs#266

This fixes two related issues.

1. Named sections are often inserted after `.bss` or `.text` in order to have them handled as if they were part of that section. Defining the start/end symbols outside of the section allows this to work.
2. Uninitialized C statics will end up as common symbols which end up in the COMMON input section. If this section is orphaned, it will likely end up placed after `.bss`. C code often expects these statics to be zero initialized. The first change would cause these symbols to be placed before `__ebss` so they will get zeroed by the reset handler. Explicitly placing the common symbols into `.bss` ensures this happens. Users who want uninitialized symbols should use the `.uninit` section.

See rust-embedded/cortex-m-rt#287 (comment)

Co-authored-by: Matt Ickstadt <mattico8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants