Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ripper in TruffleRuby due to slow performance #541

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 13, 2022

From comment:
rspec/rspec-metagem#68 (comment)

I think we should disable the usage of Ripper by RSpec for TruffleRuby, in practice it seems currently very slow (seconds of pause just before showing errors & backtraces) and so it hurts the user experience a lot more than help.

cc @eregon

@pirj pirj merged commit ddc43bc into rspec:main Apr 13, 2022
@pirj
Copy link
Member

pirj commented Apr 13, 2022

Thanks

JonRowe added a commit that referenced this pull request Sep 12, 2022
JonRowe added a commit that referenced this pull request Sep 12, 2022
JonRowe added a commit that referenced this pull request Sep 13, 2022
JonRowe added a commit that referenced this pull request Sep 13, 2022
JonRowe added a commit that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants