Add helper for running class_exec with keywords when needed #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
kwargs-class-exec
branch
4 times, most recently
from
a82ab9c
to
97d3289
Compare
benoittgt
reviewed
Apr 8, 2020
JonRowe
force-pushed
the
kwargs-class-exec
branch
from
97d3289
to
8c3a1bb
Compare
|
Merged because something odd is going on with the sub builds which means this wasn't picked up on the pinned branch. |
pirj
approved these changes
Apr 8, 2020
JonRowe
added a commit
that referenced
this pull request
May 2, 2020
Add helper for running class_exec with keywords when needed
|
On this subject https://discuss.rubyonrails.org/t/new-2-7-3-0-keyword-argument-pain-point/74980 (cc @JonRowe @pirj )
|
|
I've added a reply |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…s-class-exec Add helper for running class_exec with keywords when needed --- This commit was imported from rspec/rspec-support@ca5db55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extraction from a pr on rspec-core but its going to be a repeated pattern to fix keyword arguments across the gem so I'm adding it here. I expect to add more as I find other places that keyword arguments don't work quite right.
The aim will be to keep the string eval to a minimum and this will all be replaced with proper
**kwargsin RSpec 4, which I want to release in the later half of this year before the next version of Ruby.