From cf5a90717f71196bb00396f4145bdac780667426 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lafortune?= Date: Mon, 13 Apr 2020 16:06:04 -0400 Subject: [PATCH 1/3] Missing minimal Ruby version Please use `required_ruby_version`... Could not see any version in the README, so assuming 2.3+. --- rspec-rails.gemspec | 1 + 1 file changed, 1 insertion(+) diff --git a/rspec-rails.gemspec b/rspec-rails.gemspec index 9b84f4809d..9613b2d37d 100644 --- a/rspec-rails.gemspec +++ b/rspec-rails.gemspec @@ -11,6 +11,7 @@ Gem::Specification.new do |s| s.homepage = "https://github.com/rspec/rspec-rails" s.summary = "RSpec for Rails" s.description = "rspec-rails is a testing framework for Rails 5+." + s.required_ruby_version = ">= 2.3.0" s.metadata = { 'bug_tracker_uri' => 'https://github.com/rspec/rspec-rails/issues', From a04709e7b7379148069f5981126c613ebb350a2e Mon Sep 17 00:00:00 2001 From: Jon Rowe Date: Sat, 16 May 2020 18:10:47 +0100 Subject: [PATCH 2/3] Lower target ruby version to match Rails 5 --- .rubocop.yml | 5 +++++ rspec-rails.gemspec | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index ef904792c4..af0e19fb11 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -10,6 +10,11 @@ AllCops: Bundler/DuplicatedGem: Enabled: false +Gemspec/RequiredRubyVersion: + # Rubocop checks that the target ruby version matches the gemspec version + # but doesnt have a 2.2 option + Enabled: false + Layout/AccessModifierIndentation: Enabled: false diff --git a/rspec-rails.gemspec b/rspec-rails.gemspec index 9613b2d37d..f23b732435 100644 --- a/rspec-rails.gemspec +++ b/rspec-rails.gemspec @@ -11,7 +11,7 @@ Gem::Specification.new do |s| s.homepage = "https://github.com/rspec/rspec-rails" s.summary = "RSpec for Rails" s.description = "rspec-rails is a testing framework for Rails 5+." - s.required_ruby_version = ">= 2.3.0" + s.required_ruby_version = ">= 2.2.0" s.metadata = { 'bug_tracker_uri' => 'https://github.com/rspec/rspec-rails/issues', From f7437a518208e91cc2fe47ce4666227e32db8326 Mon Sep 17 00:00:00 2001 From: Jon Rowe Date: Sat, 16 May 2020 18:18:40 +0100 Subject: [PATCH 3/3] Change log for #2319, #2338 --- Changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog.md b/Changelog.md index 8f8cd1ac64..22168bf569 100644 --- a/Changelog.md +++ b/Changelog.md @@ -7,6 +7,7 @@ Bug Fixes: * Fix comparison of times for `#at` in job matchers. (Jon Rowe, Markus Doits, #2304) * Allow `have_enqueued_mail` to match when a sub class of `ActionMailer::DeliveryJob` is set using `.delivery_job=`. (Atsushi Yoshida #2305) +* Add `required_ruby_version` to gem spec. (Marc-André Lafortune, #2319, #2338) ### 4.0.0 / 2020-03-24 [Full Changelog](https://github.com/rspec/rspec-rails/compare/v3.9.1...v4.0.0)