Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyword arguments in dynamic methods in controller specs #2514

Merged
merged 3 commits into from Aug 14, 2021
Merged

Fix keyword arguments in dynamic methods in controller specs #2514

merged 3 commits into from Aug 14, 2021

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Aug 13, 2021 •
edited

Supersedes #2509 by demonstrating the issue in isolation from the rest of RSpec, many thanks to the original reporter @JoshCheek

@JonRowe JonRowe force-pushed the fix-ruby2-keywords-in-controller-spec-method-missing branch from 0a7f993 to 0f52603 Compare August 13, 2021 20:44
benoittgt
benoittgt approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

JonRowe added a commit that referenced this pull request Aug 13, 2021
@JonRowe
Changelog for #2509, #2514
9efdbc3
pirj
pirj approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks cleaner and more isolated.

Subjectively, I would understand the method_missing if it was defined with a proper way of delegating. Thus, not putting a shade of doubt on its participation in the failure.

spec/rspec/rails/example/controller_example_group_spec.rb Show resolved Hide resolved
spec/rspec/rails/example/controller_example_group_spec.rb Show resolved Hide resolved
JonRowe added a commit that referenced this pull request Aug 13, 2021
@JonRowe
Changelog for #2509, #2514
756af6e
@JonRowe JonRowe force-pushed the fix-ruby2-keywords-in-controller-spec-method-missing branch from 583b743 to 756af6e Compare August 13, 2021 21:37
@JonRowe JonRowe mentioned this pull request Aug 13, 2021
Closed
@JonRowe JonRowe force-pushed the fix-ruby2-keywords-in-controller-spec-method-missing branch from 756af6e to 6957188 Compare August 13, 2021 22:02
@JonRowe JonRowe merged commit dc0e2b5 into main Aug 14, 2021
@JonRowe JonRowe deleted the fix-ruby2-keywords-in-controller-spec-method-missing branch August 14, 2021 07:17
JonRowe added a commit that referenced this pull request Aug 14, 2021
@JonRowe
Merge pull request #2514 from rspec/fix-ruby2-keywords-in-controller-…
ef97e6b 
…spec-method-missing

Fix keyword arguments in dynamic methods in controller specs
@pirj
Copy link
Member

pirj commented Aug 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

@benoittgt benoittgt benoittgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonRowe @pirj @benoittgt