Prep version 5 #2476
Merged
Prep version 5 #2476
+153
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm away from the computer this weekend.
|
benoittgt
reviewed
Mar 7, 2021
| [Full Changelog](https://github.com/rspec/rspec-rails/compare/v4.1.0...main) | ||
|
|
||
| Enhancements: | ||
|
|
||
| * Support new #file_fixture_path and new fixture test support code. (Jon Rowe, #2398) | ||
| * Support for Rails 6.1. (Benoit Tigeot, Jon Rowe, Phil Pirozhkov, and more #2398) |
There was a problem hiding this comment.
Should we add more details about this?
There was a problem hiding this comment.
@benoittgt and @pirj, I intend to merge this and release 5.0 tomorrow unless either of you have anything you want to add (Im happy to delay a bit longer if so). :)
There was a problem hiding this comment.
After my message I looked at the commit list and found commits pretty technical or deprecation fix. I am wondering how much it is valuable to be in the changelog. 🤔
I have no blocker for a release. I can work for the a blog post on rspec.info next week with infos about this release.
Thanks for the work.
benoittgt
approved these changes
Mar 7, 2021
pirj
approved these changes
Mar 8, 2021
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we prepare to release Rails 6.1 support, following our new versioning strategy this means changing the major version and matching the supported Rails versions, see https://guides.rubyonrails.org/maintenance_policy.html, which is 5.2+
So this is for review of that new constraint for us, and removes a bunch of 4.2 / 5 supporting conditionals.