Add back Ruby 2.2 support for Rails 5 #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
fix-ruby22
branch
3 times, most recently
from
689fb88
to
5227212
Compare
benoittgt
approved these changes
May 13, 2020
|
@benoittgt I've temporarily suppressed our phantom error as I'd like to do a release to resolve this issue in particular |
|
No problem Jon. |
JonRowe
force-pushed
the
fix-ruby22
branch
10 times, most recently
from
79b4031
to
80bdca1
Compare
This was referenced May 15, 2020
Closed
JonRowe
force-pushed
the
fix-ruby22
branch
4 times, most recently
from
cd3e4a8
to
5792824
Compare
JonRowe
force-pushed
the
fix-ruby22
branch
2 times, most recently
from
e1bb46f
to
b705036
Compare
|
I am late but if you need some help on this @JonRowe |
JonRowe
force-pushed
the
fix-ruby22
branch
2 times, most recently
from
f341683
to
93c6f8c
Compare
|
I've just been playing whackamole with the Travis build @benoittgt 😂 I think it'll pass now, care to re-review? |
benoittgt
reviewed
May 16, 2020
| end | ||
| group.run | ||
| group.run(failure_reporter) | ||
| expect(failure_reporter.exceptions).to eq [] |
There was a problem hiding this comment.
I do not understand why we need the FailureReporter anymore?
There was a problem hiding this comment.
Its included for future debugging, we've had this spec fail before and its really hard to see why without this pattern, I'm going to use it in other places for the same reason.
There was a problem hiding this comment.
Nice! Maybe we could add a little bit of documentation on the top of file or somewhere?
benoittgt
approved these changes
May 16, 2020
JonRowe
added a commit
that referenced
this pull request
May 16, 2020
* Add extra debugging tool for specs expected to pass * Add back Ruby 2.2 support for Rails 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.