Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It supports have_enqueud_mail matcher sub class of DeliveryJob. #2305

Merged
merged 3 commits into from Mar 31, 2020

Conversation

yalab
Copy link
Contributor

@yalab yalab commented Mar 30, 2020

Hi.

I Fixed a bug.

Thanks.

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and an interesting use of the <= operator, is that documented anywhere? I've a few suggestions to the naming / grammar used but the approach is sound 👍

spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
spec/rspec/rails/matchers/have_enqueued_mail_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Please add a changelog entry.

yalab added a commit to yalab/rspec-rails that referenced this pull request Mar 31, 2020
@yalab
Copy link
Contributor Author

yalab commented Mar 31, 2020

an interesting use of the <= operator, is that documented anywhere?

See ri 'Class#<=' on your terminal.

= Class#<=

(from ruby core)
=== Implementation from Module
------------------------------------------------------------------------
  mod <= other   ->  true, false, or nil

------------------------------------------------------------------------

Returns true if mod is a subclass of other or is the
same as other. Returns nil if there's no relationship between
the two. (Think of the relationship in terms of the class definition:
"class A < B" implies "A < B".)

@JonRowe JonRowe merged commit c99d50a into rspec:master Mar 31, 2020
JonRowe added a commit that referenced this pull request Mar 31, 2020
JonRowe pushed a commit that referenced this pull request Mar 31, 2020
JonRowe added a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants