Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kwargs usage for Ruby 2.7 #2302

Merged
merged 1 commit into from Mar 26, 2020
Merged

Fix kwargs usage for Ruby 2.7 #2302

merged 1 commit into from Mar 26, 2020

Conversation

aubinlrx
Copy link

Summary

Ruby 2.7 displays warning without separation of positional and keyword arguments. This PR intend to fix it when calling the method driven_by.

rspec-rails-4.0.0/lib/rspec/rails/example/system_example_group.rb:100: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
rails-8aa14248a74c/actionpack/lib/action_dispatch/system_test_case.rb:167: warning: The called method `driven_by' is defined here

pirj
pirj approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@JonRowe
Copy link
Member

JonRowe commented Mar 26, 2020

Hurrah an easy Ruby 2.7 fix 😂

@JonRowe JonRowe merged commit d3d8555 into rspec:4-0-maintenance Mar 26, 2020
@JonRowe
Copy link
Member

JonRowe commented Mar 26, 2020

Thanks 💚 💙 💜 💛 ❤️

JonRowe added a commit that referenced this pull request Mar 26, 2020
@JonRowe
Changelog for #2302
6ffb520
JonRowe added a commit that referenced this pull request Mar 26, 2020
@JonRowe
Merge pull request #2302 from aubinlrx/tweak/deprecation_warning_ruby_27
6acc2ce 
Fix kwargs usage for Ruby 2.7
JonRowe added a commit that referenced this pull request Mar 26, 2020
@JonRowe
Changelog for #2302
bef9822
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aubinlrx @JonRowe @pirj