Truncate more method names in system tests #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: https://github.com/rspec/rspec-rails/pull/1999/files If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output. ``` File name too long @ rb_sysopen ``` The reason is the test fails, `failures_` is appended to first of file name. So I truncated it to a certain length so that the length of the file name does not become long.
JonRowe
requested changes
Dec 30, 2018
| @@ -37,7 +37,7 @@ def method_name | |||
| @method_name ||= [ | |||
| self.class.name.underscore, | |||
| RSpec.current_example.description.underscore | |||
| ].join("_").tr(CHARS_TO_TRANSLATE.join, "_")[0...251] + "_#{rand(1000)}" | |||
| ].join("_").tr(CHARS_TO_TRANSLATE.join, "_")[0...100] + "_#{rand(1000)}" | |||
There was a problem hiding this comment.
Can we have 200? It seems 50 chars would be enough for more added words, but 100 is going to be close to a normal spec files docstring length.
JonRowe
approved these changes
Dec 30, 2018
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Jan 13, 2019
* Truncate method names further in system tests ref: https://github.com/rspec/rspec-rails/pull/1999/files If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output. ``` File name too long @ rb_sysopen ``` The file name is prepended with `failures_` so further truncation is needed.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Jan 13, 2019
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* Truncate method names further in system tests ref: https://github.com/rspec/rspec-rails/pull/1999/files If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output. ``` File name too long @ rb_sysopen ``` The file name is prepended with `failures_` so further truncation is needed.
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
* Truncate method names further in system tests ref: https://github.com/rspec/rspec-rails/pull/1999/files If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output. ``` File name too long @ rb_sysopen ``` The file name is prepended with `failures_` so further truncation is needed.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/rspec/rspec-rails/pull/1999/files
If system test fails, a screenshot is taken, but if the file name exceeds 255 characters(e.g. using turnip), the following error will be output.
The reason is the test fails,
failures_is appended to first of file name.So I truncated it to a certain length so that the length of the file name does not become long.