[Fixes #1877] Do not duplicate namespace in the path name #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue #1877. If a feature spec is generated with a namespaced name, the namespace gets duplicate in the filename as well.
|
Thanks a lot @jekuta for this PR. It looks ok for me. I'm still a junior here so the merge button will be probably push by @JonRowe |
benoittgt
approved these changes
Oct 19, 2018
|
@benoittgt you can merge this if you feel its good to go, don't forget a change log :) |
benoittgt
added a commit
that referenced
this pull request
Oct 19, 2018
JonRowe
pushed a commit
that referenced
this pull request
Oct 23, 2018
[Fixes #1877] Do not duplicate namespace in the path name
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
[Fixes rspec#1877] Do not duplicate namespace in the path name
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a feature spec is generated with a namespaced name, the namespace gets duplicate in the filename as well.
The
table_namemethod returns a string that is already a combination of theclass_pathandfile_name. We could usedfile_namedirectly instead of thetable_name, which is also the approach taken in the controller generator.Closes #1877