Udpate nokogiri version #2032
Merged
Udpate nokogiri version #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbyMcWho
force-pushed
the
Update-nokogiri
branch
from
1ad0e17
to
a46e256
Compare
|
Seems like a good idea to me. 👍 The build failure on 2.4 is related to a missing DB table, not Nokogiri. A retry might help there. @BobbyMcWho would you kindly write a sentence or two in the PR description justifying this? |
JonRowe
requested changes
Oct 15, 2018
Gemfile
Outdated
| @@ -59,10 +59,12 @@ gem 'rack-cache', '< 1.3.0' if RUBY_VERSION < '2.0.0' | |||
|
|
|||
| if RUBY_VERSION < '1.9.2' | |||
| gem 'nokogiri', '~> 1.5.0' | |||
| elsif RUBY_VERSION < '1.9.3' | |||
| elsif RUBY_VERSION < '1.9.3' | |||
There was a problem hiding this comment.
Can you remove the extra space you've inserted here please.
JonRowe
approved these changes
Oct 15, 2018
BobbyMcWho
force-pushed
the
Update-nokogiri
branch
from
56c009d
to
ed2f5e2
Compare
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* Update nokogiri version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to various nokogiri CVEs, most recently sparklemotion/nokogiri#1786