Fix NoMethodError for Pathname fixture paths
#2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `fixture_path` is defined as a `Pathname` object the
`rails_fixture_file_wrapper` fails with:
NoMethodError:
undefined method `strip' for #<Pathname:0x00007fab0a970e70>
This resolves the issue by ensuring the fixture path is converted into a
string prior to resolving it.
|
Good catch! |
JonRowe
added a commit
that referenced
this pull request
Oct 23, 2018
…ixture-path Fix `NoMethodError` for `Pathname` fixture paths
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
…ame-fixture-path Fix `NoMethodError` for `Pathname` fixture paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
fixture_pathis defined as aPathnameobject therails_fixture_file_wrapperfails with:This resolves the issue by ensuring the fixture path is converted into a string prior to resolving it.