Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect long namespaces for rails g scaffold #1958

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Respect long namespaces for rails g scaffold #1958

merged 1 commit into from
Apr 27, 2018

Conversation

lauratpa
Copy link
Contributor

This PR changes the scaffold spec generator to take long namespaces
(longer than 2 elements) into consideration.

Fixes #1944

This PR changes the scaffold spec generator to take long namespaces
(longer than 2 elements) into consideration.

Fixes #1944
@benoittgt
Copy link
Member

Build is broken on one 1.9.3

Gem::RuntimeRequirementNotMetError: rake requires Ruby version >= 2.0.0. The
current ruby version is 1.9.1.
An error occurred while installing rake (12.3.1), and Bundler
cannot continue.
Make sure that `gem install rake -v '12.3.1'` succeeds before bundling.
In Gemfile:
  rails was resolved to 3.0.20, which depends on
    railties was resolved to 3.0.20, which depends on
      rake

Can we rebuild the failing job? Is there any blocking point?

@JonRowe JonRowe merged commit ced699e into rspec:master Apr 27, 2018
@JonRowe
Copy link
Member

JonRowe commented Apr 27, 2018

Thanks @jekuta and @benoittgt for the nudge

@lauratpa lauratpa deleted the fix-1944 branch April 27, 2018 08:48
JonRowe added a commit that referenced this pull request Apr 27, 2018
sebjacobs pushed a commit to futurelearn/rspec-rails that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants