From 5e0f3cacf7f5aa4bff73355b6de0ed567b05f830 Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Sun, 7 Jun 2020 15:31:17 +0300 Subject: [PATCH] Change the expectation for predicate methods Predicate methods typically return true or false, and should only exist for the uncountable and discrete, e.g. `use_transactional_fixtures?`, but not `max_formatted_output_length?`. This relates to changes made in https://github.com/rspec/rspec-core/pull/2736 --- spec/rspec/rails/configuration_spec.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spec/rspec/rails/configuration_spec.rb b/spec/rspec/rails/configuration_spec.rb index 91379ff630..5d991a5eaa 100644 --- a/spec/rspec/rails/configuration_spec.rb +++ b/spec/rspec/rails/configuration_spec.rb @@ -23,13 +23,18 @@ opts ||= {} default_value = opts[:default] alias_setting = opts[:alias_with] - query_method = "#{accessor}?".to_sym + query_method = accessor + predicate_method = "#{accessor}?".to_sym command_method = "#{accessor}=".to_sym specify "`##{query_method}` is `#{default_value.inspect}` by default" do expect(config.send(query_method)).to be(default_value) end + specify "`##{predicate_method}` is `#{!!default_value}` by default" do + expect(config.send(predicate_method)).to be(!!default_value) + end + describe "`##{command_method}`" do it "changes `#{query_method}` to the provided value" do expect {