Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an_array_matching alias for match_array #1361

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Add an_array_matching alias for match_array #1361

merged 1 commit into from
Mar 3, 2022

Conversation

markaschneider
Copy link
Contributor

This improves readability when used as an argument matcher.

expect(obj).to receive(:msg).with(an_array_matching([1, 2]))

pirj
pirj approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pirj pirj requested a review from JonRowe March 1, 2022 18:04
@JonRowe JonRowe merged commit 77889b8 into rspec:main Mar 3, 2022
@JonRowe
Copy link
Member

JonRowe commented Mar 3, 2022

Thanks!

JonRowe added a commit that referenced this pull request Sep 12, 2022
@JonRowe
Typography fixes cherry-picked from #1361
cea3682
@pirj pirj mentioned this pull request Oct 16, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markaschneider @JonRowe @pirj