Prevent malformed exception messages from exiting RSpec #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
fix-message-to_s-loop
branch
from
65b32d1
to
d936026
Compare
JonRowe
force-pushed
the
fix-message-to_s-loop
branch
from
0405330
to
c79d1f2
Compare
JonRowe
force-pushed
the
fix-message-to_s-loop
branch
from
c79d1f2
to
468c989
Compare
JonRowe
force-pushed
the
fix-message-to_s-loop
branch
from
3276f34
to
39f7ffc
Compare
pirj
reviewed
Sep 4, 2020
| # rubocop:disable Lint/RescueException | ||
| def exception_message_string(exception) | ||
| exception.message.to_s | ||
| rescue Exception => other |
There was a problem hiding this comment.
NoMemoryError.superclass # => Exception
maybe rescue from StandardError here?
There was a problem hiding this comment.
No the point is to avoid crashing due to calling this line.
There was a problem hiding this comment.
I mean we can't recover from a NoMemoryError by swallowing it.
On the other hand, SystemStackError is also an Exception, and it may be caused by an incorrectly implemented message. 👍
There was a problem hiding this comment.
Well we might be able to because we're not necessarily assigning memory, but Ruby doesn't have a system level of exception unfortunately
JonRowe
added a commit
that referenced
this pull request
Sep 30, 2020
Prevent malformed exception messages from exiting RSpec
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Prevent malformed exception messages from exiting RSpec
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…e-to_s-loop Prevent malformed exception messages from exiting RSpec --- This commit was imported from rspec/rspec-core@e6455b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception message raises when to_s is called, particularly the loop style presented by #2753, RSpec will hard loop as it tries and fails to produce a valid string for the exception, this detects and prevent this from happening and produces a reasonable stand in explanation, but its not advisable (or possible in the case of the spec example) to introspect the error itself.
Fixes #2753.