Fixes when given an array as rspec_opt
#2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…succeeding. We really should have `include(...).once` as an available matcher. rspec/rspec-expectations#685
Found because `array =~ /.../` is deprecated in 2.7 and generates a warning in Ruby 2.6.
pirj
reviewed
Mar 15, 2020
| @@ -122,7 +122,7 @@ def file_inclusion_specification | |||
| if ENV['SPEC'] | |||
| FileList[ENV['SPEC']].sort | |||
| elsif String === pattern && !File.exist?(pattern) | |||
| return if rspec_opts =~ /--pattern/ | |||
| return if [*rspec_opts].any? { |opt| opt =~ /--pattern/ } | |||
There was a problem hiding this comment.
Wondering where rspec_opts is coming from. I could only find it being assigned a nil here.
There was a problem hiding this comment.
It's a writable attribute, so it can be set directly on the task
There was a problem hiding this comment.
Here's an example using an array.
JonRowe
approved these changes
Mar 18, 2020
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
Mar 18, 2020
Fixes when given an array as `rspec_opt`
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Fixes when given an array as `rspec_opt`
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…opt_array Fixes when given an array as `rspec_opt` --- This commit was imported from rspec/rspec-core@664283f.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-core@33f15a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspec raketask's
rspec_optaccepts a string or an array of strings.In Ruby 2.7 a deprecation warning is generated for arrays. This led me to find and error that was undetected because there is no spec for the array case. Moreover I realized that the existing spec for string was erroneously written. This PR fixes both issues