Prevent invalid cause from breaking exception presenter #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet as I think something is wrong |
pirj
reviewed
Mar 9, 2020
JonRowe
force-pushed
the
ensure-exception-presenter-ignores-invalid-cause
branch
from
4898582
to
7bc3332
Compare
JonRowe
force-pushed
the
ensure-exception-presenter-ignores-invalid-cause
branch
from
7bc3332
to
dda873b
Compare
|
@pirj this is ready for review. |
pirj
approved these changes
Mar 10, 2020
JonRowe
force-pushed
the
ensure-exception-presenter-ignores-invalid-cause
branch
from
dda873b
to
0d5fde4
Compare
|
Green! |
JonRowe
force-pushed
the
ensure-exception-presenter-ignores-invalid-cause
branch
from
acf6bb0
to
4e81d92
Compare
|
Good catch @pirj, I'd forgotten to check on this 😂 I redid your fix slightly and rebased. |
JonRowe
added a commit
that referenced
this pull request
Mar 18, 2020
…s-invalid-cause Prevent invalid cause from breaking exception presenter
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…gnores-invalid-cause Prevent invalid cause from breaking exception presenter
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…eption-presenter-ignores-invalid-cause Prevent invalid cause from breaking exception presenter --- This commit was imported from rspec/rspec-core@52c3747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2701