Move Contributing section to later in README #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I can squash and clean-up these commits if there's support for this change). |
JonRowe
requested changes
Mar 2, 2019
|
@JonRowe Sure, done. |
JonRowe
approved these changes
Mar 3, 2019
|
Thanks :) |
JonRowe
pushed a commit
that referenced
this pull request
Jun 13, 2019
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…#2607) This commit was imported from rspec/rspec-core@ddd98ff.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…#2607) This commit was imported from rspec/rspec-core@6453153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor change that I think would be helpful. I think the majority of readers would be primarily interested in how to use RSpec first, before they might considering how to contribute. So I'd suggest that section should be moved further down the page. The is also in-line with what I see in most other projects, include the default README for Bundler's new gem generator.