diff --git a/hlog/hlog.go b/hlog/hlog.go index d9a60959..4f19a08a 100644 --- a/hlog/hlog.go +++ b/hlog/hlog.go @@ -3,7 +3,6 @@ package hlog import ( "context" - "net" "net/http" "time" @@ -79,10 +78,10 @@ func RequestHandler(fieldKey string) func(next http.Handler) http.Handler { func RemoteAddrHandler(fieldKey string) func(next http.Handler) http.Handler { return func(next http.Handler) http.Handler { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - if host, _, err := net.SplitHostPort(r.RemoteAddr); err == nil { + if r.RemoteAddr != "" { log := zerolog.Ctx(r.Context()) log.UpdateContext(func(c zerolog.Context) zerolog.Context { - return c.Str(fieldKey, host) + return c.Str(fieldKey, r.RemoteAddr) }) } next.ServeHTTP(w, r) diff --git a/hlog/hlog_test.go b/hlog/hlog_test.go index b1c24fe0..481525bf 100644 --- a/hlog/hlog_test.go +++ b/hlog/hlog_test.go @@ -100,7 +100,7 @@ func TestRemoteAddrHandler(t *testing.T) { })) h = NewHandler(zerolog.New(out))(h) h.ServeHTTP(nil, r) - if want, got := `{"ip":"1.2.3.4"}`+"\n", decodeIfBinary(out); want != got { + if want, got := `{"ip":"1.2.3.4:1234"}`+"\n", decodeIfBinary(out); want != got { t.Errorf("Invalid log output, got: %s, want: %s", got, want) } } @@ -116,7 +116,7 @@ func TestRemoteAddrHandlerIPv6(t *testing.T) { })) h = NewHandler(zerolog.New(out))(h) h.ServeHTTP(nil, r) - if want, got := `{"ip":"2001:db8:a0b:12f0::1"}`+"\n", decodeIfBinary(out); want != got { + if want, got := `{"ip":"[2001:db8:a0b:12f0::1]:1234"}`+"\n", decodeIfBinary(out); want != got { t.Errorf("Invalid log output, got: %s, want: %s", got, want) } }