Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger.UpdateContext checks for disabled logger using equality #643

Open
mitar opened this issue Jan 28, 2024 · 0 comments
Open

logger.UpdateContext checks for disabled logger using equality #643

mitar opened this issue Jan 28, 2024 · 0 comments

Comments

@mitar
Copy link
Contributor

mitar commented Jan 28, 2024

logger.UpdateContext checks for disabled logger:

	if l == disabledLogger {
		return
	}

I think this is problematic as it should check in a more general way, to handle also Nop and zero values. In my tests I found race conditions because I was reusing same global nop-logger. I think a better check would be something like it was done in #617. Do you agree? I can make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant