Fix docs and behavior of WithContext #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this. Was bitten by the docs not quite matching the behaviour in 1.2.6. |
pablitoc
pushed a commit
to nxcr-org/zerolog
that referenced
this pull request
Apr 7, 2023
This was referenced Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
WithContextto better match documented behavior and also updates the documentation to both clarify existing behavior as well as the behavior expected by existing tests.Note: since
WithContextno longer employs a pointer receiver, the value comparison against the Context's attached logger value must be done viareflect.DeepEqual.Fixes: #498