Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any time for a version release? :D #442

Closed
GalvinGao opened this issue Jun 5, 2022 · 8 comments
Closed

Any time for a version release? :D #442

GalvinGao opened this issue Jun 5, 2022 · 8 comments

Comments

@GalvinGao
Copy link

Hi! Firstly, huge thanks for such a wonderful package! It's really easy to use with considering the nice API design of rs/zerolog/log which is simply a global singleton. Saves me tons of frustration.

I don't want to be acting like a pushy person but, I saw that several PRs are merged to the master (notably #406 and #409) but no new release/tag are created afterwards. Is there any chance for a release/tag around those times since those features are lovely additions to what zerolog currently have! I would be glad to provide any help if there needs any :D

@GalvinGao GalvinGao changed the title Any time for release? :D Any time for a version release? :D Jun 5, 2022
@giovanism
Copy link

giovanism commented Jun 7, 2022

Seconded this. My project already has the todo to wait #409 all over places.

	// TODO: Use the updated sublogger passing via context when the following
	// patch is available. https://github.com/rs/zerolog/pull/409
	log := log.With().
		Str("event_type", ev.Context.GetType()).
		Str("event_id", ev.Context.GetID()).
		Str("event_source", ev.Context.GetSource()).
		Logger()
	ctx = (&log).WithContext(ctx)

Since I don't want to be that guy that only +1, I'll throw another question. Is there any way the releases on https://pkg.go.dev/github.com/rs/zerolog?tab=versions can be synced with the one GitHub? Got me confused there.

@GalvinGao
Copy link
Author

@giovanism The version listed on https://pkg.go.dev/github.com/rs/zerolog?tab=versions is in sync with the Git Tags, rather than GitHub Releases.

@rs
Copy link
Owner

rs commented Jun 9, 2022

I created a tag. Not sure of the value of creating gh release here.

@giovanism
Copy link

Yeah no worries about the releases not showing up here. Thanks for the release!

@GalvinGao
Copy link
Author

GalvinGao commented Jun 13, 2022

Thanks for the release! Closing this issue as it is now resolved

@GalvinGao
Copy link
Author

Ummm I might've gone wrong but on https://github.com/rs/zerolog/tags it looks like the latest is still v1.27.0.

@GalvinGao GalvinGao reopened this Jun 13, 2022
@GalvinGao
Copy link
Author

GalvinGao commented Jul 1, 2022

Ummm I might've gone wrong but on rs/zerolog/tags it looks like the latest is still v1.27.0.

cc @rs sorry for the ping but it looks like a tag is actually not been created?

@rs
Copy link
Owner

rs commented Jul 3, 2022

@rs rs closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants