ctx: Modify WithContext to use a non-pointer receiver #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Watching to see status as I am making use of this and breaking down into multiple statements including a .UpdateContext() is not as clean as the single line. |
yfuruyama
added a commit
to yfuruyama/crzerolog
that referenced
this pull request
Sep 19, 2022
yfuruyama
added a commit
to yfuruyama/crzerolog
that referenced
this pull request
Sep 19, 2022
pablitoc
pushed a commit
to nxcr-org/zerolog
that referenced
this pull request
Apr 7, 2023
mitar
reviewed
Aug 18, 2023
| if lp, ok := ctx.Value(ctxKey{}).(*Logger); ok { | ||
| if lp == l { | ||
| if lp == &l { |
There was a problem hiding this comment.
So this change makes no sense. Value receiver methods get a new copy of l every time they are called. So here you are taking an address of this temporary copied value and comparing it with context pointer. This will always be false. This has been fixed by removing this check in #499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues discussed in #116 and #400.
I have modified the receiver for
WithContextto use a non-pointer receiver and fixed the tests.The alternative to this, as discussed, would be to modify
Logger()to return a pointer. If this is the preferred fix, I'd be happy to implement. However, it will have more knock-on effects.Fixes #116.