journald: don't call Enabled before each write #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled opens and close a socket connection by reusing or initializing a global connection. I also updated go-systemd to the current development release to include the following fix: coreos/go-systemd@75f33b0 This is the only journal related change since the latest stable release
|
Thanks for the really quick merge, much appreciated! |
pablitoc
pushed a commit
to nxcr-org/zerolog
that referenced
this pull request
Apr 7, 2023
Enabled opens and close a socket connection by reusing or initializing a global connection. I also updated go-systemd to the current development release to include the following fix: coreos/go-systemd@75f33b0 This is the only journal related change since the latest stable release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled opens and close a socket connection by reusing or initializing
a global connection. It does not try to recreate the global socket connection if it failed.
It is useless to call Enabled each time.
I also updated go-systemd to the current development release to include
the following fix:
coreos/go-systemd@75f33b0
This is the only journal related change since the latest stable release.
In SFTPGo I can log to journal conditionally, with the current go-systemd version a socket is always opened even if the journal logging feature is not used, this is the reason I propose to use the latest development version while waiting for a new upstream release