Allow user configuration of default logger to return from Ctx() #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user is trying to fetch a logger from their context, they probably want to log something. In order to allow returning a useable logger from Ctx() without breaking backwards compatibilty with the previous behavior, we make it configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is trying to fetch a logger from their context, they probably want to log something.
A likely use case is the desire to fetch the logger from the context, but fall back to using the global logger if none is associated. This could facilitate migrating code towards using context-based loggers incrementally.
In order to keep backward compatibility with existing users of the library, we can add a configuration setting, which if left unchanged, causes the backwards compatible behavior. I chose to follow the existing pattern of configuration via global variables.
I hope that by making the configuration var a
*Loggerwe offer maximum flexibility to users who want this feature, while keeping the existing behaviors for users who don't. Added a unit test to cover the new case.