Add ability to customize internal json marshaler #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
requested changes
May 17, 2021
internal/cbor/base.go
Outdated
| // the functions of Encoder being invoked. | ||
| // DO REMEMBER to set this variable at importing, or | ||
| // you might get a nil pointer dereference panic at runtime. | ||
| var JSONMarshaler func(v interface{}) ([]byte, error) |
There was a problem hiding this comment.
Why nor init this as var JSONMarshFunc = json.Marshal?
There was a problem hiding this comment.
Because it's an internal package, designed for non-independent usage. I'd like to keep the setting explicitly to avoid someone happens to left out the configuration. Also I think it makes the configuration clear and global once, no confusion will be made with the default marshal func.
Added a package level variable "InterfaceMarshalFunc".
It's used to marshal interface to JSON encoded byte slice,
mostly when event.Interface("key", v) is called.
povsister
force-pushed
the
customized-interface-marshaler
branch
from
9eab6bb
to
aecc284
Compare
|
@rs Updated. PTAL |
rs
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a package level variable
InterfaceMarshalFunc. It's used to marshal interface to JSON encoded byte slice, mostly when event.Interface("key", v) is called.This enables user to replace the internal json marshaler at runtime, be noticed that using it improperly will cause potential data race.
e.g: Changing
InterfaceMarshalFuncwhile lots of events are being processed.Fixes #317