add Disabled to String and ParseLevel; add tests #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @rs - I've been working with ParseLevel recently and was wondering about
Disabled
vs.NoLevel
- there wasn't any tests for theLevel.String
method and theParseLevel
function to help me understand the behavior, so I created some. I added Disabled as well to theString()
switch statement and theParseLevel
case statement. I'm not sure if it was intentionally skipped for some reason?Thanks as always for your help!
Dan