Fix JSON when object is first to be pushed #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
reviewed
May 27, 2019
internal/json/types.go
Outdated
| // 1. new content starts with '{' - which shd be dropped OR | ||
| // 2. existing content has already other fields | ||
| // 2. new content starts with '{' - which shd be replaced with ',' to separate with existing content OR |
There was a problem hiding this comment.
shd -> should. Can you please fix the same typo on the line above too?
When pushing an object to the logger, and this object was the first field added. Zerolog was outputting an invalid json blob, issuing an extra comma before the object. This patch ensure that JSON is still valid even if an object is pushed first to the logger. Fixes rs#152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing an object to the logger, and this object was the first
field added. Zerolog was outputting an invalid json blob, issuing an
extra comma before the object. This patch ensure that JSON is still valid
even if an object is pushed first to the logger.
Fixes #152