Option to specify preflight response status code #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the recent version (
v1.8.0) there was added a change that potentially might break the clients that mistakenly relied on HTTP response code as200only (or other exotic behavior). Although, the specification does not provide the recommended status code for the preflight response, some of the clients (old browsers and/or SmartTVs) will choke on 204.In this PR we provide a way to specify the status code to use for successful OPTIONS requests in a similar way it does so in expressjs.
Along with the above changes, there is also a missing status code set for the Martini compatible handler which is fixed as well.
Related