Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Readability.FunctionNames #676

Merged
merged 5 commits into from Jul 12, 2019

Conversation

sasa1977
Copy link
Contributor

Adds some fixes and improvements to Readability.FunctionNames:

  • functions defined with parentheses are now verified (previously this check was only verifying a function if it accepts zero args and is defined without parens, i.e. def some_fun do end)
  • functions with guards (when clause) are properly handled
  • verifies private macros and custom guards
  • generates single report for multiclause functions

@rrrene
Copy link
Owner

rrrene commented Jul 12, 2019

Thx @sasa1977 👍

@sasa1977 sasa1977 deleted the improve-function-names branch July 16, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants