Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnnecessaryAliasExpansion check #640

Merged
merged 1 commit into from Mar 7, 2019

Conversation

remi
Copy link
Contributor

@remi remi commented Mar 7, 2019

I noticed we don’t have a check for this kind of code :

alias Foo.{Bar}

Alias expansion with braces is great but I think it affects the code readability when it’s used with a list containing a single item; it should be written :

alias Foo.Bar

This new UnnecessaryAliasExpansion check makes sure this rule is followed 😄

@remi remi force-pushed the feature/unnecessary-alias-expansion branch from aafe073 to 1145887 Compare March 7, 2019 12:17
@rrrene rrrene merged commit 42c507c into rrrene:master Mar 7, 2019
@rrrene
Copy link
Owner

rrrene commented Mar 7, 2019

@remiprev Nice work 👍 Thx!

@remi remi deleted the feature/unnecessary-alias-expansion branch March 7, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants