Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires(pre) for %sysusers_create_package #663

Open
socketpair opened this issue Jun 15, 2021 · 4 comments
Open

Requires(pre) for %sysusers_create_package #663

socketpair opened this issue Jun 15, 2021 · 4 comments

Comments

@socketpair
Copy link

I think if

%pre
%sysusers_create_package

is used,

Requires(pre): /usr/bin/systemd-sysusers

must also be used.

See https://bugzilla.redhat.com/show_bug.cgi?id=1972026 as an example of such bug.

@socketpair
Copy link
Author

If it is possible for macros implementation to inject dependency, It's better to fix the macros instead of rely on linters.

@marxin
Copy link
Contributor

marxin commented Jun 16, 2021

Am I right that it's only a Fedora-specific issue?

@socketpair
Copy link
Author

socketpair commented Jun 16, 2021

I don't know, possibly yes. Any checks are consequences of some packaging guidlines. But that's new feature (macros) and it could be used not only in Fedora/Centos

@Conan-Kudo
Copy link
Member

%sysusers_create_package comes from systemd itself (it ships rpm macros that it expects distros to ship), so I would expect this to be consistent across all distros. In general, we should be ensuring that systemd macros are used properly and that dependencies exist as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants