Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect undefined macros being used in %files #610

Open
sjvudp opened this issue Mar 17, 2021 · 2 comments
Open

Detect undefined macros being used in %files #610

sjvudp opened this issue Mar 17, 2021 · 2 comments

Comments

@sjvudp
Copy link

sjvudp commented Mar 17, 2021

I had a case where some undefined macro was used in %files section. rpmlint detected no error, but building the RPM failed as the resulting filename to add did not start with a slash.
Like in %{undefined}/bar when %define undefined /foo was expected.
error: File must begin with "/": %{undefined}/bar

@marxin
Copy link
Contributor

marxin commented Mar 17, 2021

Seems like a good idea. Are you willing to prepare a pull request for it?

@danigm
Copy link
Member

danigm commented Mar 15, 2023

Isn't this solved here https://github.com/rpm-software-management/rpmlint/blob/main/rpmlint/checks/FilesCheck.py#L632?

Maybe we just need a test for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants