{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":31258089,"defaultBranch":"master","name":"rpm","ownerLogin":"rpm-software-management","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-02-24T12:00:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8504469?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716198957.0","currentOid":""},"activityList":{"items":[{"before":"3af92952580000b321e97400aff7c89203d65281","after":null,"ref":"refs/tags/rpm-4.20.0-alpha2","pushedAt":"2024-05-20T09:55:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"}},{"before":"3b3c94845abae7de138dcd0288842768575be9e8","after":"4e37e714aa39b25e435a794b05819f8a99b025be","ref":"refs/heads/rpm-4.20.x","pushedAt":"2024-05-20T09:55:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Update OpenSSL requirement in INSTALL too\n\nThis should've been part of commit\n200c91ff72ecfdf4751913e672660ffc0a680ff6.\n\n(cherry picked from commit d97ce26c01dc4e2bda5f39df518c921fc901b160)","shortMessageHtmlLink":"Update OpenSSL requirement in INSTALL too"}},{"before":"3d38573b72a093d5cd4171417776a88f32d135b3","after":"d97ce26c01dc4e2bda5f39df518c921fc901b160","ref":"refs/heads/master","pushedAt":"2024-05-20T09:51:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Update OpenSSL requirement in INSTALL too\n\nThis should've been part of commit\n200c91ff72ecfdf4751913e672660ffc0a680ff6.","shortMessageHtmlLink":"Update OpenSSL requirement in INSTALL too"}},{"before":"fd056ff39e1d86fbfd012db113be4949af786eb0","after":"3d38573b72a093d5cd4171417776a88f32d135b3","ref":"refs/heads/master","pushedAt":"2024-05-20T05:48:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Convert the various dependency checking hashes from rpmhash to STL\n\nThis isn't very idiomatic C++ but NULL pointers are used for logic\nso references wont do, and as for filedepHashFree() and\ndepexistsHashFree(): deleting and NULL'ing all these pointers manually\nadds up.","shortMessageHtmlLink":"Convert the various dependency checking hashes from rpmhash to STL"}},{"before":"7188cf8ecf6a98486582125f7b8aca1abbd43f92","after":"3b3c94845abae7de138dcd0288842768575be9e8","ref":"refs/heads/rpm-4.20.x","pushedAt":"2024-05-17T11:36:56.000Z","pushType":"pr_merge","commitsCount":85,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Preparing for rpm 4.20.0-alpha2\n\nCommit 5ce5604831611327e521973427d684837968663e added a new public API\nfunction so bump the minor lib version, \"pin\" the new test hashes also.","shortMessageHtmlLink":"Preparing for rpm 4.20.0-alpha2"}},{"before":"5e7ba21047ae03cb74d6b3457f33e59782ed7c00","after":"fd056ff39e1d86fbfd012db113be4949af786eb0","ref":"refs/heads/master","pushedAt":"2024-05-17T08:36:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix a regression on dependency generator namespace directive\n\nCommit ce6c3812af4c2a9e9fc6c2dc77e00e1e1487bb83 accidentally changed\nthis namespace string literal too, oops. Possible because there was\nno test on it, so add one.","shortMessageHtmlLink":"Fix a regression on dependency generator namespace directive"}},{"before":"749f1cea9a37693ddd1632bd7d4fe7b497f64fd8","after":"5e7ba21047ae03cb74d6b3457f33e59782ed7c00","ref":"refs/heads/master","pushedAt":"2024-05-17T08:25:38.000Z","pushType":"pr_merge","commitsCount":10,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Use an STL string for constructing the macro in rpmfcAttrMacroV()","shortMessageHtmlLink":"Use an STL string for constructing the macro in rpmfcAttrMacroV()"}},{"before":"4fc4ee91f412d3326268b7eda970ab9160d0820f","after":"749f1cea9a37693ddd1632bd7d4fe7b497f64fd8","ref":"refs/heads/master","pushedAt":"2024-05-16T07:15:45.000Z","pushType":"pr_merge","commitsCount":12,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Convert file attribute tracking hash from rpmhash to STL","shortMessageHtmlLink":"Convert file attribute tracking hash from rpmhash to STL"}},{"before":"69c837a4361ff2d1e7ec562c397c6caf0081fd7c","after":"4fc4ee91f412d3326268b7eda970ab9160d0820f","ref":"refs/heads/master","pushedAt":"2024-05-16T06:41:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Clean up applyAttr() and rpmfcHelper() interaction\n\nApply the attributes in applyAttr() as per the name, and pass *that*\nindex array to rpmfcHelper() which only needs to concern itself with\ngenerating the path arrays as per the used protocol.\n\nNo functional changes, doing this in \"raw C\" because this refactor\nis worth cherry-picking to 4.20 too, but also because doing this\nfirst makes converting to STL easier.","shortMessageHtmlLink":"Clean up applyAttr() and rpmfcHelper() interaction"}},{"before":"54a3912e81870d920a477bb24a38a21e8c4eb768","after":"69c837a4361ff2d1e7ec562c397c6caf0081fd7c","ref":"refs/heads/master","pushedAt":"2024-05-14T11:16:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Improve the debuginfo enablement backwards compatibility\n\nMove the enablement logic to %__spec_install_template where it can be\nburied with relatively little danger of being overridden by distros or\npackagers. It's moderately annoying as the logic isn't no longer neatly in\none spot, but %__spec_install_post is commonly overridden by distros\nand even packages, and in particular we don't want to have packages\ncopy-paste all this stuff along, because that makes making any changes\nto this stuff even harder than it already is.\n\nThis should be entirely backwards compatible with all the pre-existing\n%__spec_install_post overrides.\n\nCo-authored-by: Florian Festi <ffesti@redhat.com>","shortMessageHtmlLink":"Improve the debuginfo enablement backwards compatibility"}},{"before":"ed1f2da3d7925d33788626af40ad78ccc649051b","after":"54a3912e81870d920a477bb24a38a21e8c4eb768","ref":"refs/heads/master","pushedAt":"2024-05-14T07:18:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Free old cookie value to prevent a memory leak\n\nThis keeps the old behaviour of overriding the cookie. This may not me\ncorrect as the code looks like it reads the cookie from the srpm when\ndoing rpmbuild --rebuild for the purpose of preserving it. Otoh the\ncurrent behaviour with overriding it even in this case has been around\nfor years. This whole cookie business seems to have some other issues,\ntoo, and needs further investigation. Here we are only trying to fix the\nmemory leak.","shortMessageHtmlLink":"Free old cookie value to prevent a memory leak"}},{"before":"71f2ca495043b9f63e3f21d43e88624040406a62","after":"ed1f2da3d7925d33788626af40ad78ccc649051b","ref":"refs/heads/master","pushedAt":"2024-05-13T13:25:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Fix test-suite under Fedora 40 modern C rules\n\nMultiple tests are failing on Fedora 40 due to their distro-wide\nC modernization effort, which cause our ancient \"hello world\" package\nto fail due to implicit printf() function usage.\n\nThere are two separate issues here:\n- hello-autopatch.spec had off-by-one in its patch application, causing\n  the modernization patch to not apply (see #3093 for the reason)\n- others were using the original hello-1.0-1.src.rpm from 2007 with\n  some very outdated practises, code and md5 hashes\n\nUpdate the src.rpm, removing silly fubar while we're at it. Regenerated\nnow on x86_64 so adjust the test-expectation, and update the python archive\ntest to calculate sha256 instead. And, fix the autopatch test numbers.","shortMessageHtmlLink":"Fix test-suite under Fedora 40 modern C rules"}},{"before":"8535694599ee7f35747d44e2ea0a62dc5e8880e5","after":"71f2ca495043b9f63e3f21d43e88624040406a62","ref":"refs/heads/master","pushedAt":"2024-05-13T12:48:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"cmake: move os-release parsing into oci branch\n\nos-release parsing is only needed for OCI usage, so move it inside the\nappropriate branch. Saves some operations at build time when not needed,\nand also it is necessary as not all OSes define VERSION_ID (e.g.: Debian\nUnstable and Archlinux)","shortMessageHtmlLink":"cmake: move os-release parsing into oci branch"}},{"before":"f3f9f2c7b1f19b2d7f5ed9cd21a22e730680fe6f","after":"8535694599ee7f35747d44e2ea0a62dc5e8880e5","ref":"refs/heads/master","pushedAt":"2024-05-13T08:38:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Add proper logic for debuginfo enablement\n\nAll these years, enabling debuginfo has required distros to hijack the\nspec %install section with a macro like this:\n\n    %install %{?_enable_debug_packages:%{?buildsubdir:%{debug_package}}}\\\n    %%install\\\n    %{nil}\n\nThis for a widely used, longtime upstream supported feature is just\ngross, and also very non-obvious, feeble and whatnot. And totally\nprevents the new append/prepend options from being used with %install.\n\nTake advantage of several newish features to make this happen: we need\nexpressions to properly handle the numeric %_enable_debug_packages value\nfrom a macro, and if enabled, output the debuginfo template as a dynamic\n.specpart.\n\nEnable debuginfo on Linux by default in the platform configuration.\nNotably noarch should not have debuginfo so it's disabled in the\nplatform configuration - since 96467dce18f264b278e17ffe1859c88d9b5aa4b6\nwe can now actually rely on the platform configuration being valid,\nso we can drop the \"%ifnarch noarch\" from the debug package check.\nFurther streamlining should be possible.\n\nNote that the old %install hack MUST BE REMOVED from distros now.\n\nAs a nice bonus, this makes debuginfo work for packages that don't use\n%setup. Add an explicit test for this in the \"rpmbuild %caps\" test.\nspecstep.spec needs to be made noarch here, otherwise it'll now try\nto produce debuginfo and fail.\n\nCo-authored-by: Florian Festi <ffesti@redhat.com>\n\nFixes: #2204\nFixes: #1878","shortMessageHtmlLink":"Add proper logic for debuginfo enablement"}},{"before":"f69fae984a40fae9de487cc4050d9b0e81549ecf","after":"f3f9f2c7b1f19b2d7f5ed9cd21a22e730680fe6f","ref":"refs/heads/master","pushedAt":"2024-05-13T08:08:47.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Always create %specpartsdir on build\n\nThere's no reason %specpartsdir should be dependent on %setup use,\njust create it when we create the build directory too. Update tests\naccordingly.\n\nThe spec parse test is noteworthy, the specparts dir creation no longer\nshows up in spec parse output, which certainly is the way it should be:\nthis is rpm internal infrastructure stuff and nothing to do with spec\n*parse*, this all only takes place during builds.\n\nFixes: #3063","shortMessageHtmlLink":"Always create %specpartsdir on build"}},{"before":"16759ef4717bc75a860dbbbc848d5913277d1a14","after":"f69fae984a40fae9de487cc4050d9b0e81549ecf","ref":"refs/heads/master","pushedAt":"2024-05-08T06:43:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Delete leftover file trigger definitions\n\nThese just are leftovers from 861e92fd0a4f02367180ab1786048062aded8861\nwhere trigger stuff was moved to their own header.","shortMessageHtmlLink":"Delete leftover file trigger definitions"}},{"before":"0f6ed3c68ad5c7090159d644c5fd21656461d7ab","after":"16759ef4717bc75a860dbbbc848d5913277d1a14","ref":"refs/heads/master","pushedAt":"2024-05-08T06:40:10.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Convert orderInfo array to a vector","shortMessageHtmlLink":"Convert orderInfo array to a vector"}},{"before":"97c0889cba90d483f79f08d455ab7f99add9824a","after":"0f6ed3c68ad5c7090159d644c5fd21656461d7ab","ref":"refs/heads/master","pushedAt":"2024-05-08T06:29:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Simplify rpmfi replaced sized management\n\nrpmfi always internally stores 64bit sizes since 4.6.0, there's no\nreason to do anything else with replaced sizes either.","shortMessageHtmlLink":"Simplify rpmfi replaced sized management"}},{"before":"bbb28b3fe50896386c598b6eb1f156059fb90a89","after":"97c0889cba90d483f79f08d455ab7f99add9824a","ref":"refs/heads/master","pushedAt":"2024-05-08T06:29:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace rpmhash with STL unordered_map in headerformat cache\n\nA notable difference is that we're now storing the rpmtd structs\nthemselves in the hash, rather than pointers to them.\n\nA minor side-cleanup is that headerGet() does not return data on failure\nso there's no need to free anything in that case.","shortMessageHtmlLink":"Replace rpmhash with STL unordered_map in headerformat cache"}},{"before":"058c96c2636a1e52061daf4bb3c18ed9bda7c6ab","after":"bbb28b3fe50896386c598b6eb1f156059fb90a89","ref":"refs/heads/master","pushedAt":"2024-05-08T06:29:17.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace dependency lookup cache with an STL unordered map\n\nAnnoyingly, rpmdbProvides() can get called with a NULL dcache so we\ncan't use a reference for passing it around. Dynamically allocating\nit would be silly so just pass a pointer to the local variable around\ninstead (to avoid otherwise unnecessary code changes)","shortMessageHtmlLink":"Replace dependency lookup cache with an STL unordered map"}},{"before":"39119680de80b473ba41d5562c6d3d23fa1d6b93","after":"058c96c2636a1e52061daf4bb3c18ed9bda7c6ab","ref":"refs/heads/master","pushedAt":"2024-05-07T06:51:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Implement proper user/group lookup caching with STL maps\n\nIt may not make much difference for performance for our current\nuse-cases, but since it's not really any more code now... besides proper\ncaching, this is far more safer for callers as the returned C-strings\nwill remain valid until the next rpmugFree() rather than next lookup.\n\nNatively allocate the rpmug struct to enable this.","shortMessageHtmlLink":"Implement proper user/group lookup caching with STL maps"}},{"before":"18f7e53951afe54b488edd882e3d479429c2f629","after":"39119680de80b473ba41d5562c6d3d23fa1d6b93","ref":"refs/heads/master","pushedAt":"2024-05-07T06:16:12.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace home-grown hashes with STL unordered_map in rpmal\n\nThe size heuristics in the rpmalMake*Index() functions should be\nrevisisted for the STL containers, we don't know whether these values\nmake much sense now.","shortMessageHtmlLink":"Replace home-grown hashes with STL unordered_map in rpmal"}},{"before":"96467dce18f264b278e17ffe1859c88d9b5aa4b6","after":"18f7e53951afe54b488edd882e3d479429c2f629","ref":"refs/heads/master","pushedAt":"2024-05-06T09:08:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Remove C++ guards from internal headers\n\nWhile these were necessary to get things going, they are only\ncounterproductive now: we want to be able to freely use C++ features\ninside rpm.","shortMessageHtmlLink":"Remove C++ guards from internal headers"}},{"before":"dde4fe5cf7d2b543f1fb1f2212679273492ed7e7","after":"96467dce18f264b278e17ffe1859c88d9b5aa4b6","ref":"refs/heads/master","pushedAt":"2024-05-06T07:28:44.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Automatically reload rpm configuration on mismatching BuildArch\n\nWhen BuildArch is encountered during spec parse, rpm recurses the\nparse, but this doesn't reset/reload the global configuration and macros\nto match. So eg a \"BuildArch: noarch\" package gets built with a\ndramatically different macros depending on whether \"--target noarch\"\nwas used or not, whereas people expect it to be the same - after all we\ngive zero indication that anything might be wrong when --target wasn't\nspecified.\n\nAutomatically detect and handle this condition in the rpmbuild tool:\nif the spec parse architecture disagrees with our loaded configuration,\nrequest a reparse with reloaded configuration for the matching target.\nThis ensures 'rpmbuild -bb noarch.spec' and 'rpmbuild -bb --target\nnoarch noarch.spec' run with the same exact configuration.\nDoing this also fixes the situation where build-time macro expansion\nof build scriptlets (for template bits and dynamically generated spec\nparts) yields totally different (bogus) than in the initial spec parse.\nThis also goes for RPM_ARCH environment and similar.\n\nAvoid --undefine for dependency generation test, it doesn't work.\n--undefine with --target was always broken, now it's just more visible\nsince it automatically applies to BuildArch too. Fixing that is a\nseparate matter (#3070).\n\nA more sophisticated fix could be having a stack of macro contexts that we\ncopy, push and pop as necessary. That ought to solve the undefine too.\n\nFixes: #3049","shortMessageHtmlLink":"Automatically reload rpm configuration on mismatching BuildArch"}},{"before":"b8d8bfab0374bc6cca05b70f526c245908f5dc94","after":"dde4fe5cf7d2b543f1fb1f2212679273492ed7e7","ref":"refs/heads/master","pushedAt":"2024-04-30T06:07:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Drop architecture from %builddir path\n\nThis causes more issues than it solves, at least presently. For one,\nwhen BuildArch is used it typically causes the path to disagree with the\nactual arch (eg on noarch packages). Which looks weird and causes yet\nother issues in turn. The other issue, raised by Neal Gompa, is that\nit can cause superfluous path differences in noarch subpackages, which\nsharing the noarch package across multiple architectures in at least\nkoji.\n\nUse -build suffix instead of %{_arch}. -build may seem redundant since\nby default it's in BUILD directory already, but this makes it more\nobvious in cases where the default is overridden (eg fedpkg overrides to\ncurrent directory), and helps differentiating it from the %buildsubdir\ndirectory commonly created by %setup.\n\nSuggested-by: Neal Gompa <neal@gompa.dev>","shortMessageHtmlLink":"Drop architecture from %builddir path"}},{"before":"d10b1765815369d13ee925451a8ba3df16f4ee8c","after":"b8d8bfab0374bc6cca05b70f526c245908f5dc94","ref":"refs/heads/master","pushedAt":"2024-04-30T06:06:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix header source/patch names disagreeing with src.rpm contents\n\nIf sources or patches in the spec are defined via a macro that does not\nyet exist, it'll still work for building if the macro has been defined\nby that time as there's another round of expansion there. But this can\nleave the source/patch names inserted to the header disagreeing with\nwhat actually ended up in the source package, eg in the testcase\nyou'd previously get '%{somemacro}-2.0.tar.gz' in the header whereas\nthe src.rpm had the right contents.\n\nWhile defining sources this way seems mad and brittle, it does actually\nwork for building rpms and there's a whole ecosystem of packages relying\non it in Fedora. So lets at least be consistent about it, and re-expand\nthe source paths once more before inserting in the header, because\nthat's what happens for them in the actual build as well.\n\nOriginally reported at https://bugzilla.redhat.com/show_bug.cgi?id=2233878","shortMessageHtmlLink":"Fix header source/patch names disagreeing with src.rpm contents"}},{"before":"1f66db34599eea8ffb9761c51bff92991e57ca7b","after":"d10b1765815369d13ee925451a8ba3df16f4ee8c","ref":"refs/heads/master","pushedAt":"2024-04-30T06:06:32.000Z","pushType":"pr_merge","commitsCount":12,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Natively allocate plugin structures, use a vector for storage","shortMessageHtmlLink":"Natively allocate plugin structures, use a vector for storage"}},{"before":"667e32cd959635756ba900ad915740c43ba5d302","after":"1f66db34599eea8ffb9761c51bff92991e57ca7b","ref":"refs/heads/master","pushedAt":"2024-04-30T06:06:24.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Untangle the per-name stack from the macro entry struct\n\nUse an STL stack to store the macro entries sharing the name to separate\nthe data from its containing structure, this lets the macro entries be\nproper C++ objects that manage their own business only and thus can be\nalso directly stored containers, doing away with manual allocation.\n\nAnd now that these entries no longer need any special care, we can\ndelete all the copy-control fubar from the main macro context: it's all\nstandard library storage now and don't need our handholding.","shortMessageHtmlLink":"Untangle the per-name stack from the macro entry struct"}},{"before":"f23483f62919403cf44fadc01b2519f439e5ff37","after":"667e32cd959635756ba900ad915740c43ba5d302","ref":"refs/heads/master","pushedAt":"2024-04-26T14:30:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Fix spelling and grammar in conditionalbuilds.md","shortMessageHtmlLink":"Fix spelling and grammar in conditionalbuilds.md"}},{"before":"695b5c25213823390daa6495c65d79e5a8c792f5","after":"f23483f62919403cf44fadc01b2519f439e5ff37","ref":"refs/heads/master","pushedAt":"2024-04-25T10:25:02.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace temporary argv array in Lua posix.exec() with a vector","shortMessageHtmlLink":"Replace temporary argv array in Lua posix.exec() with a vector"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETqRRwgA","startCursor":null,"endCursor":null}},"title":"Activity · rpm-software-management/rpm"}