Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for adding file contents directly to a package, without needing to create files #207

Open
dralley opened this issue Dec 22, 2023 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@dralley
Copy link
Collaborator

dralley commented Dec 22, 2023

Currently we have API like this, for adding files:

    .with_file(
        "./test_assets/awesome.py",
        rpm::FileOptions::new("/usr/bin/awesome"),
    )?

and API like this, for adding scriptlets

    .pre_install_script("echo preinst")

the former assumes that you already have a file that exists, unlike the latter which takes the contents directly. This is a bit awkward.

We should probably consolidate this a bit, such that a user can easily create their package using either paths to existing files, OR directly providing the contents of the files.

@dralley dralley added the good first issue Good for newcomers label Dec 22, 2023
@dralley dralley self-assigned this Jan 6, 2024
dralley added a commit to dralley/rpm-rs that referenced this issue Jan 6, 2024
dralley added a commit to dralley/rpm-rs that referenced this issue Jan 6, 2024
dralley added a commit to dralley/rpm-rs that referenced this issue Jan 6, 2024
dralley added a commit to dralley/rpm-rs that referenced this issue Jan 7, 2024
dralley added a commit to dralley/rpm-rs that referenced this issue Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant