Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject or strip Unicode control characters? #192

Open
dralley opened this issue Nov 7, 2023 · 1 comment
Open

Reject or strip Unicode control characters? #192

dralley opened this issue Nov 7, 2023 · 1 comment

Comments

@dralley
Copy link
Collaborator

dralley commented Nov 7, 2023

Unicode control characters in metadata cause downstream issues, particularly with regards to the XML metadata that is eventually generated when making a repository out of these RPMs.

rpm-software-management/rpm#2742
rpm-software-management/createrepo_c#327

We should consider sanitizing inputs or rejecting invalid ones that we know have the potential to cause problems. Of course, with the focus of this package being a library rather than a build tool, I can also see an argument that this logic belongs elsewhere (e.g. a consumer of the library). I'm of mixed opinion at the moment but it's worth a discussion.

@dralley
Copy link
Collaborator Author

dralley commented Jan 13, 2024

Example: rpm names have a restricted character set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant