Drop cpio-rs, replace with vendored code #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
commented
Mar 23, 2023
cmeister2
reviewed
Mar 23, 2023
|
Could you outline the exact differences/changes required to make the existing CPIO work? |
|
Note to self: make sure we handle the edge cases discussed here: https://blog.colindou.ch/posts/lets-make-an-os-cpio-weirdness/ That is: be careful with directories, and be careful with absolute paths. Extracting a cpio shouldn't automatically overwrite /usr/bin/blah. |
dralley
force-pushed
the
cpio
branch
3 times, most recently
from
3d665e0
to
36c567c
Compare
This is necessary because RPM uses a modified CPIO format to support >4gb file sizes. To maximize similarity and avoid producing nonsensical RPM payloads, we should do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because RPM uses a modified CPIO format to support
>4gb file sizes. To maximize similarity and avoid producing nonsensical
RPM payloads, we should do the same.
closes #108
馃摐 Checklist
--all-featuresenabled