Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template highlight of braces in CPP lexer #1839

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Jun 25, 2022

Fix highlight of braces {} in template statement in CPP lexer.

I have also added an example and verified it via the visual test site.

Screen Shot 2022-06-25 at 10 46 04 am

Closes #1837

@tancnle tancnle force-pushed the bugfix.cpp-template-braces branch from 83817da to 7e7f39a Compare June 25, 2022 00:50
@tancnle
Copy link
Collaborator Author

tancnle commented Jun 25, 2022

👋🏼 @MC-DeltaT could you kindly review this PR and see if it addresses the reported issue? 🙏🏼

@tancnle tancnle self-assigned this Jun 25, 2022
@MC-DeltaT
Copy link

I honestly have very little knowledge of this repo, so not sure I'm any good as a reviewer...
But if it addresses those two examples with the lambda and requires then I'm happy. I guess "punctuation" is the most appropriate token type.

Thanks for fixing it so quickly!

@tancnle tancnle merged commit d17a6af into rouge-ruby:master Jun 28, 2022
@tancnle tancnle deleted the bugfix.cpp-template-braces branch June 28, 2022 03:18
razetime pushed a commit to razetime/rouge that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ lambda in default template argument is incorrectly highlighted as error
2 participants