Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more Jenkins pipeline name variations in groovy lexer #1836

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

danilaml
Copy link
Contributor

Copy link
Collaborator

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @danilaml ❤️ I have added a tiny suggestion. Please let me know what you think.

lib/rouge/lexers/groovy.rb Show resolved Hide resolved
@tancnle tancnle added the author-action The PR has been reviewed but action by the author is needed label Jun 23, 2022
@tancnle
Copy link
Collaborator

tancnle commented Jun 24, 2022

Awesome. Thank you for the prompt action on this @danilaml. Let's ship it! 🚀

@tancnle tancnle merged commit 303943c into rouge-ruby:master Jun 24, 2022
@tancnle tancnle removed the author-action The PR has been reviewed but action by the author is needed label Jun 24, 2022
@danilaml danilaml deleted the patch-1 branch June 24, 2022 00:49
razetime pushed a commit to razetime/rouge that referenced this pull request Jun 30, 2022
…ruby#1836)

* Support more Jenkins pipeline name variations in groovy lexer

Support *.Jenkinsfile patters

* Add missing spec to groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants