Add Meson Lexer #1732
Add Meson Lexer #1732
Conversation
There was a problem hiding this comment.
Thank you for your contribution @funatsufumiya ❤️ And welcome to Rouge. The PR looks good to be overall. I have left some suggestions for your consideration.
In addition, could you kindly:
- add some specs for this lexer, mostly around guessing (see Python spec for inspiration)
- rebase this branch off master and add an entry to the
Languages.md
Please let me know what you think 🙏🏼
lib/rouge/lexers/meson.rb
Outdated
| title "Meson" | ||
| desc "Meson's specification language" | ||
| tag 'meson' | ||
| filenames 'meson.build' |
There was a problem hiding this comment.
suggestion: Do you think we could consider specifying a mimetype as well?
mimetypes 'text/x-meson'
| rule %r/\@/, Str::Interpol, :pop! | ||
| end | ||
|
|
||
| class StringRegister < Array |
There was a problem hiding this comment.
thought (non-blocking): Since this inner-class is shared with the one in the Python lexer, I would suggest extracting this to a common place to reduce duplication. No action is required in this PR. I will take point on the follow-up PR.
tancnle
added
the
author-action
Co-authored-by: Tan Le <tan.le@hey.com>
Co-authored-by: Tan Le <tan.le@hey.com>
|
@tancnle |
No worries @funatsufumiya. In the spirit of iteration, let's merge this change for now 🚀 I can have a look at implementing them or you might beat me into it :) |
This adds a lexer for Meson (https://mesonbuild.com/Syntax.html)