Fix lexing of jsl messages and nested block comments #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
approved these changes
Dec 5, 2020
|
@BenPH Thanks for adding this! I've merged it in and it will be part of the next release of Rouge. That's scheduled for Tuesday (or Wednesday depending on your time zone) of next week 👍 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
…ls in JSL lexer (rouge-ruby#1638) This commit adds support to the JSL lexer for: - messages that don't end with `(` or `;`; - nested block comments; - the missing operators `` ` `` and `^`; - decimals that start with `.`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes for the JSL lexer
<<Some Messagewhere they aren't terminated with()or;`(transpose) and^(exponentiation).as Nums.by itself ismissingand is considered a number as well