Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long options to Batchfile lexer #1626

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Nov 9, 2020

The Batchfile lexer does not support 'long options' (i.e. options that begin with --). This PR adds support for that.

It fixes #1599.

@pyrmont pyrmont self-assigned this Nov 9, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Nov 9, 2020
@pyrmont
Copy link
Contributor Author

pyrmont commented Nov 9, 2020

@fireattack Thanks for reporting this and sorry it took a bit of time to get back to you. I think this PR fixes the issue :)

@pyrmont pyrmont merged commit 5a40f6f into rouge-ruby:master Nov 10, 2020
@pyrmont pyrmont deleted the bugfix.batchfile-switches branch November 10, 2020 01:16
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Nov 10, 2020
@pyrmont
Copy link
Contributor Author

pyrmont commented Nov 10, 2020

@fireattack This will be part of the next release of Rouge, v3.25.0. That's scheduled for release later today/tomorrow (depending on your time zone). Thanks again for filing the issue! 🎉

@fireattack
Copy link

Awesome, thanks for the hard work!

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
The Batchfile lexer does not support 'long options' (i.e. options that
begin with --). This commit adds support for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batchfile's double-dash (two hyphens) long options are highlighted wrong
3 participants