Improve support for sigils in Perl lexer #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Phroneris Thanks for reporting the bug. I confess that as a non-Perl programmer, Perl's use of sigils comes across as super weird. I suspect these changes to the rules will match syntactically incorrect Perl but since syntax correctness is a non-goal of Rouge, this seemed like a decent balance between clarity and correctness. |
|
@pyrmont I strongly agree about Perl's weirdness. Thanks a lot. |
jneen
approved these changes
Nov 9, 2020
|
@Phroneris This will be part of the next release of Rouge, v3.25.0. That's scheduled for release later today/tomorrow (depending on your time zone). Thanks again for the bug report! |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Perl supports a variety of different sigils (`$`, `@`, `%`, etc). This commit improves support for some of the more unusual combinations of sigils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl supports a variety of different sigils (
$,@,%, etc). This PR improves support for some of the more unusual combinations of sigils.It fixes #1619.