Fix template string lexing in JavaScript lexer #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishalsatam Thanks for reporting the bug. This was a regression that mistakenly crept in as a result of some maintenance we did in the last release. This PR should fix it :) |
|
@vishalsatam This has been merged into master and will be part of v3.25.0. That's schedule for release later today (or tomorrow depending on your time zone)! |
|
@pyrmont Thank you so much and I appreciate the quick turnaround time. |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The changes made in rouge-ruby#1548 to avoid empty regular expression patterns, broke the template string rules in the JavaScript lexer (and lexers such as the TypeScript lexer that inherit from it). This commit adds the rules necessary to fix this lexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in #1548 to avoid empty regular expression patterns, broke the template string rules in the JavaScript lexer (and lexers such as the TypeScript lexer that inherit from it). This PR adds the rules necessary to fix this lexing.
It fixes #1616.